kate522andClaude Fable 5
1549d5b25d
Fixes two issues:
1. **Balance recharge disabled on fresh install**: The `pay_balance_s`
setting has `default: true` in SchemaPayment but was treated as
disabled when the key was absent from the database. This meant users
had to toggle it off and back on to activate the feature.
Fixed by using `!isset() || !empty()` pattern to honor the schema
default when the key is missing.
2. **PHP Warning in withdrawal settings**: `get_withdrawal_settings()`
passed `$s['affiliate_withdrawal_reset_time']` directly to
`preg_match()` without extracting it first, causing "Undefined
array key" warnings when the option was unset.
Fixed by extracting to `$reset_time_raw` before the regex check.
Changed:
- `PaymentRuntime::get_payment_recharge_settings()`: enabled defaults to true
- `PaymentRuntime::get_payment_gateway_settings()`: balance_enabled defaults to true
- `PaymentRuntime::is_gateway_enabled('balance')`: defaults to true
- `PaymentRuntime::get_withdrawal_settings()`: no longer warns on missing key
Added test script `tools/test-payment-runtime-defaults.php` to verify
the fix works with empty settings (fresh install).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
101 lines
3.5 KiB
PHP
101 lines
3.5 KiB
PHP
<?php
|
|
/**
|
|
* Test script to verify PaymentRuntime default values work correctly
|
|
* when database options are empty (fresh install scenario).
|
|
*
|
|
* Usage: php tools/test-payment-runtime-defaults.php
|
|
*/
|
|
|
|
// Simulate WordPress environment
|
|
define('ABSPATH', dirname(__DIR__) . '/');
|
|
define('WPINC', 'wp-includes');
|
|
|
|
// Load Composer autoload
|
|
require_once dirname(__DIR__) . '/vendor/autoload.php';
|
|
|
|
// Mock WordPress functions
|
|
if (!function_exists('__')) {
|
|
function __($text, $domain = 'default') { return $text; }
|
|
}
|
|
if (!function_exists('esc_url_raw')) {
|
|
function esc_url_raw($url) { return $url; }
|
|
}
|
|
if (!function_exists('sanitize_text_field')) {
|
|
function sanitize_text_field($str) { return trim(strip_tags($str)); }
|
|
}
|
|
if (!function_exists('sanitize_textarea_field')) {
|
|
function sanitize_textarea_field($str) { return trim(strip_tags($str)); }
|
|
}
|
|
if (!function_exists('sanitize_key')) {
|
|
function sanitize_key($key) { return strtolower(preg_replace('/[^a-z0-9_\-]/', '', $key)); }
|
|
}
|
|
if (!function_exists('wp_kses_post')) {
|
|
function wp_kses_post($data) { return $data; }
|
|
}
|
|
|
|
// Mock Settings class with empty data
|
|
class MockSettings {
|
|
public static function get_all(): array {
|
|
// Simulate fresh install: empty settings
|
|
return [];
|
|
}
|
|
public static function credits_enabled(): bool { return true; }
|
|
public static function download_default_cost(): int { return 0; }
|
|
}
|
|
|
|
// Replace the real Settings class with mock
|
|
class_alias('MockSettings', 'Jio\Settings\Settings');
|
|
|
|
// Now test PaymentRuntime
|
|
use Jio\Settings\PaymentRuntime;
|
|
|
|
echo "Testing PaymentRuntime with empty database (fresh install)...\n\n";
|
|
|
|
// Test 1: Recharge settings
|
|
echo "1. Testing get_payment_recharge_settings():\n";
|
|
$recharge = PaymentRuntime::get_payment_recharge_settings();
|
|
echo " - enabled: " . ($recharge['enabled'] ? 'true' : 'false') . " (expected: true)\n";
|
|
echo " - withdraw_enabled: " . ($recharge['withdraw_enabled'] ? 'true' : 'false') . " (expected: false)\n";
|
|
if ($recharge['enabled'] !== true) {
|
|
echo " ❌ FAIL: 'enabled' should be true by default!\n";
|
|
} else {
|
|
echo " ✅ PASS: 'enabled' is true\n";
|
|
}
|
|
echo "\n";
|
|
|
|
// Test 2: Gateway settings
|
|
echo "2. Testing get_payment_gateway_settings():\n";
|
|
$gateway = PaymentRuntime::get_payment_gateway_settings();
|
|
echo " - balance_enabled: " . ($gateway['balance_enabled'] ? 'true' : 'false') . " (expected: true)\n";
|
|
if ($gateway['balance_enabled'] !== true) {
|
|
echo " ❌ FAIL: 'balance_enabled' should be true by default!\n";
|
|
} else {
|
|
echo " ✅ PASS: 'balance_enabled' is true\n";
|
|
}
|
|
echo "\n";
|
|
|
|
// Test 3: is_gateway_enabled
|
|
echo "3. Testing is_gateway_enabled('balance'):\n";
|
|
$balance_enabled = PaymentRuntime::is_gateway_enabled('balance');
|
|
echo " - Result: " . ($balance_enabled ? 'true' : 'false') . " (expected: true)\n";
|
|
if ($balance_enabled !== true) {
|
|
echo " ❌ FAIL: balance gateway should be enabled by default!\n";
|
|
} else {
|
|
echo " ✅ PASS: balance gateway is enabled\n";
|
|
}
|
|
echo "\n";
|
|
|
|
// Test 4: Withdrawal settings (no warning)
|
|
echo "4. Testing get_withdrawal_settings() (should not trigger PHP warning):\n";
|
|
try {
|
|
$withdrawal = PaymentRuntime::get_withdrawal_settings();
|
|
echo " - reset_time: " . $withdrawal['reset_time'] . " (expected: 00:00)\n";
|
|
echo " - min_amount: " . $withdrawal['min_amount'] . " (expected: 50.00)\n";
|
|
echo " ✅ PASS: No PHP warning triggered\n";
|
|
} catch (Throwable $e) {
|
|
echo " ❌ FAIL: " . $e->getMessage() . "\n";
|
|
}
|
|
echo "\n";
|
|
|
|
echo "All tests completed.\n";
|